search

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
121 stars 91 forks source link

Add constructor to convert NLLS to OptimizationProblem #538

Closed Vaibhavdixit02 closed 8 months ago

Vaibhavdixit02 commented 8 months ago

Fixes https://github.com/SciML/Optimization.jl/issues/622

codecov[bot] commented 8 months ago

Codecov Report

Merging #538 (5d3ab7a) into master (ffe68ae) will decrease coverage by 0.10%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   41.07%   40.98%   -0.10%     
==========================================
  Files          53       53              
  Lines        4051     4060       +9     
==========================================
  Hits         1664     1664              
- Misses       2387     2396       +9
Files Coverage Δ
src/problems/basic_problems.jl 65.65% <0.00%> (-6.57%) :arrow_down:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

ChrisRackauckas commented 8 months ago

Looks ready to merge? In-place is going to be much more common than out of place, so that would be good to support, but a proper error message is fine for now.

Vaibhavdixit02 commented 8 months ago

Yeah should be ready. But I don't completely like the interface, it needs the adtype as positional arg for the OptimizationProblem constructor for the "automatic" conversion but can't see any other way to do it for now.