search

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
121 stars 91 forks source link

Propagate IIP information in the Wrapper Functions #543

Closed avik-pal closed 8 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (ece1966) 41.71% compared to head (d7f5284) 29.06%.

Files Patch % Lines
src/function_wrappers.jl 40.00% 24 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #543 +/- ## =========================================== - Coverage 41.71% 29.06% -12.65% =========================================== Files 53 53 Lines 4123 4142 +19 =========================================== - Hits 1720 1204 -516 - Misses 2403 2938 +535 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avik-pal commented 8 months ago

https://github.com/SciML/SciMLBase.jl/actions/runs/6882931820/job/18722452216?pr=543#step:6:544 is due to https://github.com/JuliaTesting/Aqua.jl/pull/202

avik-pal commented 8 months ago

Sundials failure I checked locally goes away with this PR + https://github.com/JuliaDiff/SparseDiffTools.jl/pull/275