SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
121 stars 91 forks source link

feat: add support for new symbol indexing methods in SII #571

Closed AayushSabharwal closed 6 months ago

AayushSabharwal commented 6 months ago

Requires https://github.com/SciML/SymbolicIndexingInterface.jl/pull/18

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (f17b506) 30.50% compared to head (1bdb65c) 30.42%.

Files Patch % Lines
src/integrator_interface.jl 0.00% 12 Missing :warning:
src/solutions/ode_solutions.jl 0.00% 9 Missing :warning:
src/problems/problem_interface.jl 0.00% 6 Missing :warning:
src/solutions/solution_interface.jl 0.00% 5 Missing :warning:
ext/SciMLBaseZygoteExt.jl 0.00% 2 Missing :warning:
src/ensemble/ensemble_solutions.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #571 +/- ## ========================================== - Coverage 30.50% 30.42% -0.09% ========================================== Files 53 53 Lines 4019 4030 +11 ========================================== Hits 1226 1226 - Misses 2793 2804 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AayushSabharwal commented 6 months ago

CI won't pass, because it depends on MTK

AayushSabharwal commented 6 months ago

cjdoris/julia-downgrade-compat-action@v1 is pinning stdlib dependencies too, so it doesn't resolve on versions other than 1.9

ChrisRackauckas commented 6 months ago

okay, we'll bump to v1.10 soon. Ignore for now