search

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
131 stars 97 forks source link

Aqua CI #574

Open ArnoStrouwen opened 9 months ago

ArnoStrouwen commented 9 months ago

I'm not sure how DiffEqScalar works, since the reported method ambiguity seems like it should be regularly called. For the type piracy, this can be solved by giving L a type. If the type is AbstractDiffEqOperator then the method can stay here, but if it is AbstractSciMLOperator then the method should move.

https://github.com/SciML/SciMLBase.jl/actions/runs/7359078663/job/20033302904?pr=574#step:6:728 https://github.com/SciML/SciMLBase.jl/actions/runs/7359078663/job/20033302904?pr=574#step:6:747

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (416ca0a) 30.42% compared to head (cfa45b0) 5.20%.

Files Patch % Lines
src/operators/basic_operators.jl 0.00% 2 Missing :warning:
src/operators/diffeq_operator.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #574 +/- ## ========================================== - Coverage 30.42% 5.20% -25.22% ========================================== Files 53 53 Lines 4030 3994 -36 ========================================== - Hits 1226 208 -1018 - Misses 2804 3786 +982 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 9 months ago

Those operators were deprecated and their documentation was deleted long ago. I think it's time to just remove them.