Closed lxvm closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
416ca0a
) 30.42% compared to head (4ca3c23
) 27.18%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
this pr could also be a good time to decide on the promotion behavior for the endpoints of the integration domain. I actually think promotion should be handled at solve time since it could interfere with AD, e.g. using ForwardDiff and differentiating just the upper limit of integration.
Yes that's how we do it with the other problem types so it makes sense to do the same thing on IntegralProblem.
I think this just needs to update the related tests and its good to go.
Fixes https://github.com/SciML/Integrals.jl/issues/198 Fixes https://github.com/SciML/Integrals.jl/issues/208
Specifically, this pr deprecates the following method:
@ChrisRackauckas this pr could also be a good time to decide on the promotion behavior for the endpoints of the integration domain. I actually think promotion should be handled at solve time since it could interfere with AD, e.g. using ForwardDiff and differentiating just the upper limit of integration.
Checklist
Additional context
Add any other context about the problem here.