SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
131 stars 97 forks source link

fix: fix several bugs related to remake and symbolic indexing #583

Closed AayushSabharwal closed 7 months ago

AayushSabharwal commented 9 months ago

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (350e3d8) 39.44% compared to head (7ca2602) 0.00%. Report is 81 commits behind head on master.

Files Patch % Lines
src/remake.jl 0.00% 26 Missing :warning:
src/solutions/rode_solutions.jl 0.00% 11 Missing :warning:
src/problems/problem_interface.jl 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #583 +/- ## ========================================== - Coverage 39.44% 0.00% -39.45% ========================================== Files 53 53 Lines 4039 3964 -75 ========================================== - Hits 1593 0 -1593 - Misses 2446 3964 +1518 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 9 months ago

Add some inference tests as well.

ChrisRackauckas commented 8 months ago

What's next here?

AayushSabharwal commented 8 months ago

Nothing, it just needs this to be tagged first, which I assume will happen with MTKv9

ChrisRackauckas commented 8 months ago

Looks like there's a circle where tests can't pass?

AayushSabharwal commented 8 months ago

MTK tests should pass regardless of this PR

ChrisRackauckas commented 8 months ago

What's the status of this one?

AayushSabharwal commented 8 months ago

This PR needs https://github.com/SciML/ModelingToolkit.jl/pull/2409 to be tagged

AayushSabharwal commented 8 months ago

TODO: Symbolic remake won't work with SymbolCache as the system as user-provided symbols. I think now that SII exists, process_p_u0_symbolic should be able to be implemented in SciMLBase and be independent of where the symbols come from?

AayushSabharwal commented 8 months ago

CI won't pass here until https://github.com/SciML/ModelingToolkit.jl/pull/2409 is merged and tagged. I also have plans to remove process_p_u0_symbolic from MTK and just handle it in SciMLBase using SII. This would allow for symbolic initialization using DSLs (SymbolCache) as well.

isaacsas commented 7 months ago

Is there any update on this or the PRs this requires before it can be merged?

AayushSabharwal commented 7 months ago

This PR is too old to be merged, and the required changes are now different than what this PR intended. I'll open a new one soon