Closed AayushSabharwal closed 7 months ago
Attention: 40 lines
in your changes are missing coverage. Please review.
Comparison is base (
350e3d8
) 39.44% compared to head (7ca2602
) 0.00%. Report is 81 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
src/remake.jl | 0.00% | 26 Missing :warning: |
src/solutions/rode_solutions.jl | 0.00% | 11 Missing :warning: |
src/problems/problem_interface.jl | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Add some inference tests as well.
What's next here?
Nothing, it just needs this to be tagged first, which I assume will happen with MTKv9
Looks like there's a circle where tests can't pass?
MTK tests should pass regardless of this PR
What's the status of this one?
This PR needs https://github.com/SciML/ModelingToolkit.jl/pull/2409 to be tagged
TODO: Symbolic remake won't work with SymbolCache
as the system as user-provided symbols. I think now that SII exists, process_p_u0_symbolic
should be able to be implemented in SciMLBase and be independent of where the symbols come from?
CI won't pass here until https://github.com/SciML/ModelingToolkit.jl/pull/2409 is merged and tagged. I also have plans to remove process_p_u0_symbolic
from MTK and just handle it in SciMLBase using SII. This would allow for symbolic initialization using DSLs (SymbolCache
) as well.
Is there any update on this or the PRs this requires before it can be merged?
This PR is too old to be merged, and the required changes are now different than what this PR intended. I'll open a new one soon
Checklist
Additional context
Add any other context about the problem here.