SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
119 stars 91 forks source link

feat: add support for ParameterIndexingProxy #584

Closed AayushSabharwal closed 5 months ago

AayushSabharwal commented 6 months ago

Checklist

Additional context

Add any other context about the problem here.

AayushSabharwal commented 6 months ago

Requires https://github.com/SciML/SymbolicIndexingInterface.jl/pull/26

codecov[bot] commented 6 months ago

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (8188851) 30.43% compared to head (e25f46d) 30.48%. Report is 6 commits behind head on master.

Files Patch % Lines
src/problems/basic_problems.jl 0.00% 2 Missing :warning:
src/problems/problem_interface.jl 60.00% 2 Missing :warning:
src/solutions/optimization_solutions.jl 0.00% 2 Missing :warning:
src/integrator_interface.jl 50.00% 1 Missing :warning:
src/solutions/dae_solutions.jl 50.00% 1 Missing :warning:
src/solutions/ode_solutions.jl 50.00% 1 Missing :warning:
src/solutions/rode_solutions.jl 50.00% 1 Missing :warning:
src/solutions/solution_interface.jl 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #584 +/- ## ========================================== + Coverage 30.43% 30.48% +0.04% ========================================== Files 53 54 +1 Lines 4045 4068 +23 ========================================== + Hits 1231 1240 +9 - Misses 2814 2828 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 6 months ago

Regression? https://github.com/SciML/SciMLBase.jl/actions/runs/7421883120/job/20196120178?pr=584#step:6:1407

AayushSabharwal commented 6 months ago

No, a badly written test I think 😅

AayushSabharwal commented 5 months ago

Requires https://github.com/SciML/SymbolicIndexingInterface.jl to be merged and tagged

ChrisRackauckas commented 5 months ago

All SciMLSensitivity tests just started failing? https://github.com/SciML/SciMLBase.jl/actions/runs/7567194901/job/20605897599?pr=584#step:6:1328 @AayushSabharwal was this something form RAT?

AayushSabharwal commented 5 months ago

Yep. It doesn't like some of the adjoints again. ~Why did I ever touch them~

ChrisRackauckas commented 5 months ago

Can you yank that last release?

AayushSabharwal commented 5 months ago

SciMLSensitivity won't pass until after https://github.com/SciML/RecursiveArrayTools.jl/pull/337

ChrisRackauckas commented 5 months ago

@AayushSabharwal make sure to follow up on the JumpProcesses.jl downstream.