Prepare `DAESolution` for interpolation

SciML / SciMLBase.jl

The Base interface of the SciML ecosystem

https://docs.sciml.ai/SciMLBase/stable

MIT License

119 stars 91 forks source link

Prepare `DAESolution` for interpolation #622

Closed oscardssmith closed 4 months ago

oscardssmith commented 4 months ago

Checklist

[ ] Appropriate tests were added
[x] Any code changes were done in a way that does not break public API
[x] All documentation related to code changes were updated
[x] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[x] Any new documentation only uses public API

Additional context

Add any other context about the problem here. This adds the k field to DAESolution which will allow for a future PR to OrdinaryDiffEq to make DAEs save their k's which is necessary to interpolate their solutions.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7611e76) 38.81% compared to head (a2627da) 38.81%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #622 +/- ## ======================================= Coverage 38.81% 38.81% ======================================= Files 55 55 Lines 4261 4261 ======================================= Hits 1654 1654 Misses 2607 2607 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 4 months ago

@avik-pal https://github.com/SciML/SciMLBase.jl/actions/runs/7885674097/job/21517306694?pr=622#step:6:1876