fix: remove usages of `syms`/`paramsyms`/`indepsym` keyword argument

AayushSabharwal commented 4 months ago

Close #618

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

codecov[bot] commented 4 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0475fc3) 38.81% compared to head (8898aa2) 38.77%.

Files	Patch %	Lines
src/scimlfunctions.jl	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #624 +/- ## ========================================== - Coverage 38.81% 38.77% -0.05% ========================================== Files 55 55 Lines 4261 4261 ========================================== - Hits 1654 1652 -2 - Misses 2607 2609 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oscardssmith commented 4 months ago

isn't there still a lot of code that uses these fields if the sys is unavailable?

ChrisRackauckas commented 4 months ago

Is there? I don't know of any at least. It should've been throwing warnings for at least a few months now?

SciML / SciMLBase.jl