SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
118 stars 91 forks source link

test, docs: fix tests and docs for MTKv9 #634

Closed AayushSabharwal closed 3 months ago

AayushSabharwal commented 4 months ago

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 37.54%. Comparing base (0998e07) to head (e5e1172).

Files Patch % Lines
src/scimlfunctions.jl 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #634 +/- ## ========================================== + Coverage 28.86% 37.54% +8.67% ========================================== Files 55 55 Lines 4285 4294 +9 ========================================== + Hits 1237 1612 +375 + Misses 3048 2682 -366 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AayushSabharwal commented 4 months ago

There are more fixes than it looks like there are, I'm working on this locally. MTK needs a couple changes to support indexing with Symbols (prob.ps[:a] to refer to @parameters a)

ChrisRackauckas commented 4 months ago

Rebase this. I fixed some test cases

AayushSabharwal commented 4 months ago

Requires the fix in https://github.com/SciML/ModelingToolkit.jl/pull/2524