SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
118 stars 91 forks source link

allow `integrand_prototype` for oop integral functions #636

Closed lxvm closed 4 months ago

lxvm commented 4 months ago

Previously, IntegralFunction(f, integrand_prototype) would error for oop f and this pr makes it possible to pass an oop f because the integrand_prototype is still useful to infer the return type of f without evaluating it. Integral algorithms often need to have a prototype to have a correct wrapper so this will avoid additional integrand evaluations.

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 26.19%. Comparing base (d45b79a) to head (263f910). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #636 +/- ## ========================================== - Coverage 26.26% 26.19% -0.07% ========================================== Files 55 55 Lines 4283 4279 -4 ========================================== - Hits 1125 1121 -4 Misses 3158 3158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.