fix: fix remake and indexing

AayushSabharwal commented 2 months ago

Close #660 Close #661 Close https://github.com/SciML/ModelingToolkit.jl/issues/2637

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 2.56410% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 31.43%. Comparing base (7fbd1cf) to head (65c7b3f). Report is 6 commits behind head on master.

Files	Patch %	Lines
src/problems/problem_interface.jl	0.00%	24 Missing :warning:
ext/SciMLBaseZygoteExt.jl	0.00%	14 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #668 +/- ## ========================================== + Coverage 31.29% 31.43% +0.13% ========================================== Files 55 55 Lines 4358 4470 +112 ========================================== + Hits 1364 1405 +41 - Misses 2994 3065 +71 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 2 months ago

Test fails https://github.com/SciML/SciMLBase.jl/actions/runs/8684483802/job/23812149496?pr=668#step:6:1416

AayushSabharwal commented 2 months ago

What's cancelling the tests? Codecov?

SciML / SciMLBase.jl