SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
118 stars 91 forks source link

Add ADTypes 1.0 compat #674

Closed gdalle closed 2 months ago

gdalle commented 2 months ago

Checklist

Additional context

ADTypes is about to release a breaking v1.0, so the task of updating downstream repos begins. This is a test PR to see if there is anything to change here. From what I can tell, the only use of ADTypes in SciMLBase is through AbstractADType, which is still available, so we should be good.

However note that this PR is not yet testing with ADTypes v1.0, so we won't know for sure what happens. In particular, restricting ADTypes v1.0 to Julia v1.10 and above (as we decided in https://github.com/SciML/ADTypes.jl/pull/40#issuecomment-2053606366) is probably very breaking throughout the ecosystem.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.86%. Comparing base (0ec4159) to head (4984f1c). Report is 3 commits behind head on master.

:exclamation: Current head 4984f1c differs from pull request most recent head 30e985f. Consider uploading reports for the commit 30e985f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #674 +/- ## ========================================== - Coverage 40.84% 4.86% -35.99% ========================================== Files 55 55 Lines 4490 4443 -47 ========================================== - Hits 1834 216 -1618 - Misses 2656 4227 +1571 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdalle commented 2 months ago

@ChrisRackauckas thoughts on how to proceed here? I don't think we can really prepare draft PRs everywhere until ADTypes v1.0 is registered. We'd need to install ADTypes from the repo every single time, as well as all other dependencies (for instance SciMLBase), which means a huge chain of interlinked PR branches

ChrisRackauckas commented 2 months ago

I think it's fine to merge since this is just the interface, and thus it won't actually be used until the downstream users (currently Optimization.jl and NonlinearSolve.jl) allow it. This then isolates the problem to the downstream places where it's actually used, which should be fine.

gdalle commented 2 months ago

I guess this deserves a minor version bump?

gdalle commented 2 months ago

Hi! Now that https://github.com/SciML/ADTypes.jl/issues/46 is done, if ADTypes v1 doesn't break CI for SciMLBase, would it be possible to release v2.34?