SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
118 stars 91 forks source link

Chore: remove mentions of SDESolution #683

Closed DhairyaLGandhi closed 2 months ago

DhairyaLGandhi commented 2 months ago

Checklist

Additional context

SDESolution doesn't seem to exist anymore. The more appropriate type seems to be RODESolution. This PR removes mentions of SDESolution and replaces them with RODESolution. Further, one of the adjoints was incorrect. It was definining an adjoint over SDEProblem, but instead tries returning SDESolution in the forwards pass. Not sure how this passed tests though

Add any other context about the problem here.

AayushSabharwal commented 2 months ago

Could you add a test that differentiates through an SDEProblem solve? That way we can verify the new gradients work and ensure they continue to do so

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 31.64%. Comparing base (1238b2b) to head (ae40a6c). Report is 11 commits behind head on master.

Files Patch % Lines
ext/SciMLBaseZygoteExt.jl 0.00% 19 Missing :warning:
ext/SciMLBaseChainRulesCoreExt.jl 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================== - Coverage 31.72% 31.64% -0.08% ========================================== Files 55 55 Lines 4505 4519 +14 ========================================== + Hits 1429 1430 +1 - Misses 3076 3089 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.