refactor: move type-pirated function from BoundaryValueDiffEq here, use Accessors.jl

AayushSabharwal commented 1 month ago

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 30.82%. Comparing base (9185795) to head (17a165c).

Files	Patch %	Lines
src/solutions/ode_solutions.jl	44.00%	14 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #696 +/- ## =========================================== - Coverage 41.53% 30.82% -10.71% =========================================== Files 55 55 Lines 4582 4577 -5 =========================================== - Hits 1903 1411 -492 - Misses 2679 3166 +487 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 1 month ago

Fix conflict?

AayushSabharwal commented 1 month ago

I'm looking into what is cancelling these tests

AayushSabharwal commented 4 weeks ago

Requires https://github.com/SciML/RecursiveArrayTools.jl/pull/384

SciML / SciMLBase.jl