SciML / SciMLBase.jl

The Base interface of the SciML ecosystem
https://docs.sciml.ai/SciMLBase/stable
MIT License
118 stars 91 forks source link

Fix `EnsembleSummary` plot recipe kwarg #697 #700

Closed jonathanfischer97 closed 1 month ago

jonathanfischer97 commented 1 month ago

In reference to #697:

Tests

Further considerations or to-dos

  1. Was the original intention of the EnsembleSummary recipes to allow users to choose/truncate the amount of trajectories that statistics are plotted over, similar to EnsembleSimulation? (Explains the mixup with idxs)

    • If so, that functionality is missing and should be added
  2. Symbolic indexing does not work any of the recipes for either EnsembleSimulation or EnsembleSummary.

    • Should be added to match the recipe of AbstractSolution.
  3. Plotting state spaces via giving idxs as a Tuple rather than a Vector does not work.

    • Should also be added to match the non-ensemble solution plotting recipes, if intended by the maintainers.
  4. Makie EnsembleSummary recipe doesn't show transparent ranges: image Shown are 100 trajectories.

  5. No user-exposed way to set the color map of EnsembleSimulation trajectories? Would like an easy way to set it to something other than random, like this:

    image