Closed vpuri3 closed 1 year ago
Merging #210 (734205b) into master (f169b36) will increase coverage by
0.80%
. The diff coverage is73.41%
.
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 70.31% 71.12% +0.80%
==========================================
Files 10 10
Lines 1533 1562 +29
==========================================
+ Hits 1078 1111 +33
+ Misses 455 451 -4
Impacted Files | Coverage Δ | |
---|---|---|
src/func.jl | 84.55% <73.41%> (+3.48%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Should we just remove the vec
in that spot of OrdinaryDiffEq if it's hitting an operator?
We will remove the entire WOperator object evenetually.
The idea behind this PR is that we should support vec'd arrays anyway because one or the other downstream packages would use it. I've added warnings, docs etc all over the place as well. So after this PR, I believe we will be hitting all use cases and this package will be as versatile as it gets.
We should also move preconditioner tests to interfaceII in ODE.jl
BTW the failing test in preconditioner.jl
is passing now
@ChrisRackauckas
with this branch,