SciML / SciMLTutorials.jl

Tutorials for doing scientific machine learning (SciML) and high-performance differential equation solving with open source software.
https://tutorials.sciml.ai
Other
719 stars 127 forks source link

Update most if not all notebooks #33

Closed finmod closed 5 years ago

finmod commented 6 years ago

@ChrisRackauckas Can you or someone please update most if not all notebooks in DiffEqTutorials to run smoothly on current Julia v1.0.1 and DifferentialEquations v5.3.1. For a fruitful dissemination of Julia DiffEq, it is important that this collection of notebooks runs flawlessly.

ChrisRackauckas commented 6 years ago

Indeed. In fact, I want to remove the notebooks and instead make this all pdfs and notebooks generated by Weave.jl. I think that would be a lot more maintainable.

HenriLaurie commented 5 years ago

I think this has become urgent (well, a bit selfishly, I am due to teach Julia and JuliaDiffEq in 4 weeks time). I'd like to make a start, at least with the intro notebooks, and can see easy changes for all except the code-optimisations ... but now what about Weave.jl?

I like the idea of a weave, but have never actually walked the talk of writing code and documentation as one.

If we are to go to Weave I can see two problems --- Weave is not working properly for me (am on v1.1, Weave's tests say they pass but they do throw warnings and error messages, the examples from the Weave repository rely on Gadfly which doesn't currently pass tests and doesn't precompile when I try using it). --- I am confused by all the options in Weave and in particular do not have a workflow/environment where I can edit, run the code, and preview the rendering of pdf and html output.

I'd suggest separating the two: people like me start updating the notebooks, and some-one with expertise in Weave.jl takes the initiative with that.

ChrisRackauckas commented 5 years ago

I do have a branch I was working on: https://github.com/JuliaDiffEq/DiffEqTutorials.jl . Let me push some of the updated notebooks this weekend.

ChrisRackauckas commented 5 years ago

This PR has the updates for the introduction notebooks already done: https://github.com/JuliaDiffEq/DiffEqTutorials.jl/pull/36

ChrisRackauckas commented 5 years ago

Everything has a translation, a few of them need to get finished.

HenriLaurie commented 5 years ago

By translation I guess you mean to weave? I viewed the conversation on #36 but am not sure how I could view the notebooks, do I need to wait for the PR to go through to master? I will certainly read/test them as soon as they come through (well, as soon as I see they're there), anything else I could do?

On Sun, 24 Feb 2019 at 16:27, Christopher Rackauckas < notifications@github.com> wrote:

Everything has a translation, a few of them need to get finished.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JuliaDiffEq/DiffEqTutorials.jl/issues/33#issuecomment-466781935, or mute the thread https://github.com/notifications/unsubscribe-auth/AUQTBzO77giDaQr8CPQR7VElbaVSMWTIks5vQqFjgaJpZM4XwJpV .

ChrisRackauckas commented 5 years ago

Do you still want notebooks? Or are PDFs and webpages good? We can output notebooks but for now I was just building the two former

HenriLaurie commented 5 years ago

Well, I could go on with pdf/html but notebooks are definitely better, they're so much easier to play with, superb for teaching.

On Mon, 25 Feb 2019 at 13:59, Christopher Rackauckas < notifications@github.com> wrote:

Do you still want notebooks? Or are PDFs and webpages good? We can output notebooks but for now I was just building the two former

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JuliaDiffEq/DiffEqTutorials.jl/issues/33#issuecomment-466985469, or mute the thread https://github.com/notifications/unsubscribe-auth/AUQTBw23-MXp2qoUDi4-BgaGIGLCruhhks5vQ9AFgaJpZM4XwJpV .

ChrisRackauckas commented 5 years ago

Complete.

@HenriLaurie there are some issues with Weave.jl's notebook output which we can track here: https://github.com/JuliaDiffEq/DiffEqTutorials.jl/issues/37 . But other than that, everything is updated to v1.0 so I'm closing this.

ChrisRackauckas commented 5 years ago

@HenriLaurie Notebook output has been fixed. There's a small rendering issue that'll get fixed soon in Weave and then that'll be good to go.