search

SciML / StochasticDiffEq.jl

Solvers for stochastic differential equations which connect with the scientific machine learning (SciML) ecosystem
Other
248 stars 66 forks source link

Fix `handle_callback_modifiers!` #391

Open devmotion opened 3 years ago

devmotion commented 3 years ago

The current implementation seems wrong (see https://github.com/SciML/StochasticDelayDiffEq.jl/pull/35#discussion_r564026139).

It seems it is not tested currently and hence a test should be added. What would be a simple example that fails currently?

ChrisRackauckas commented 3 years ago

It would be a callback in https://github.com/SciML/StochasticDiffEq.jl/blob/master/test/tau_leaping.jl since the P term only applies to tau-leaping.