Closed rmsrosa closed 2 years ago
@oscardssmith https://github.com/SciML/StochasticDiffEq.jl/runs/7886061441?check_suite_focus=true#step:6:424 I think you caused a downstream failure.
@frankschae can you track down the regression in the weak adaptive GPU? I think it's a KernelAbstractions.jl Rational support bug, so @vchuravy might need an MWE.
But this looks fine to merge.
This needs a test which would catch it.
Yeah, a test is good. Just added some.
This changes the way
reset
is done for a newsolve
in a way to accommodate noises of typeNoiseFunction
.It checks for
W.curt != t
instead ofW.t[end] != t
, so it works for the usual noises, which do have the fieldt
and for whichW.curt
is the same asW.t[end]
, and forNoiseFunction
s, which do not have the fieldt
.To be fully functional, this depends on implementing a proper dispatch of
reinit!
toNoiseFunction
in SciML/DiffEqNoiseProcesses.jl, as proposed in the PR https://github.com/SciML/DiffEqNoiseProcess.jl/pull/114.This should close #493.
With these things implemented, we get the proper behavior (c.f. #493):
And preserving the behavior for "regular" noises