Closed sumiya11 closed 8 months ago
As I understand, we should bump Nemo.jl versions to 0.32-0.38 in StructuralIdentifiability.jl ?
At the moment, ParamPunPam.jl restricts Nemo.jl to 0.32-0.37, and StructuralIdentifiability.jl restricts Nemo.jl to 0.24-0.38. Hence, the lowest possible bound is 0.32
As I understand, we should bump Nemo.jl versions to 0.32-0.38 in StructuralIdentifiability.jl ?
At the moment, ParamPunPam.jl restricts Nemo.jl to 0.32-0.37, and StructuralIdentifiability.jl restricts Nemo.jl to 0.24-0.38. Hence, the lowest possible bound is 0.32
Yes, I agree 0.32 looks like the lowest feasible
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5d71f49
) 89.90% compared to head (c3bab78
) 89.90%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note for future self: make sure that Groebner.jl v0.6.1 supports Nemo.jl v0.39 (currently v0.6.0 does not https://github.com/sumiya11/Groebner.jl/blob/v0.6.0/Project.toml)
In the light of https://github.com/SciML/StructuralIdentifiability.jl/pull/260
@pogudingleb thanks for fixing this! I also have this check in Groebner.jl now
Trying out this new compat CI thing..
See https://julialang.slack.com/archives/CN04R7WKE/p1702296727671319 and https://github.shali-sdc4.acirock.com/marketplace/actions/downgrade-julia-compat-entries