search

SciML / StructuralIdentifiability.jl

Fast and automatic structural identifiability software for ODE systems
https://docs.sciml.ai/StructuralIdentifiability/stable/
MIT License
110 stars 17 forks source link

Fix type piracy #263

Closed sumiya11 closed 7 months ago

sumiya11 commented 8 months ago

Running CI..

The lower bound on the AA.jl version is changed since AbstractAlgebra.vars for fractions is released in v0.34.5: https://github.com/Nemocas/AbstractAlgebra.jl/releases/tag/v0.34.5

Merge me before #253

sumiya11 commented 8 months ago

Now Groebner.jl (0.6.3) handles both Nemo.GF/Nemo.Native.GF, and ParamPunPam.jl (0.3.1) internally uses Nemo.Native.GF.

Therefore, here, I decided to set sharp lower bounds for Groebner.jl and ParamPunPam.jl.

sumiya11 commented 8 months ago

Now that MTK seems to have dropped support for Julia 1.6, should we move to Julia 1.9 as well? @pogudingleb

pogudingleb commented 8 months ago

Now that MTK seems to have dropped support for Julia 1.6, should we move to Julia 1.9 as well? @pogudingleb

Are you asking because you foresee any problems with keeping 1.6?

Is there any discussion about dropping the support of 1.6 in MTK? The LTS seem to be still 1.6 according to the Julia webpage...

sumiya11 commented 8 months ago

Are you asking because you foresee any problems with keeping 1.6?

It could be harder to maintain mtk_to_si and friends in SI.jl, since we would't get updates from MTK and Symbolics anymore.

Is there any discussion about dropping the support of 1.6 in MTK?

Not that I know of, unfortunately

pogudingleb commented 7 months ago

Superseded by #274