Render ModelingToolkit as an extension

pogudingleb commented 8 months ago

The goals are:

increase loading time if the MTK interface is not used
allow testing and releasing for earlier versions of Julia than 1.10

Todo:

separate the code to an extension (kind-of done)
arrange the tests with different Julia versions (kind-of done)
fix the docs (kind-of done)
switch to the new finite fields (done)
create an additional non-MTK interface for discrete-time systems (kind-of done)

codecov[bot] commented 8 months ago

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (7633afd) 89.90% compared to head (aad9b56) 89.84%. Report is 2 commits behind head on master.

Files	Patch %	Lines
ext/ModelingToolkitExt.jl	90.16%	18 Missing :warning:
src/input_macro.jl	90.59%	11 Missing :warning:
src/util.jl	84.21%	3 Missing :warning:
src/ODEexport.jl	0.00%	2 Missing :warning:
src/discrete.jl	98.59%	1 Missing :warning:
src/parametrizations.jl	83.33%	1 Missing :warning:
src/wronskian.jl	80.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #266 +/- ## ========================================== - Coverage 89.90% 89.84% -0.07% ========================================== Files 25 27 +2 Lines 3209 3268 +59 ========================================== + Hits 2885 2936 +51 - Misses 324 332 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sumiya11 commented 7 months ago

I seem to have some issues with dependencies on 1.9.4:

(si-1.9) pkg> add ModelingToolkit
(si-1.9) pkg> dev .
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package Symbolics [0c5d862f]:
 Symbolics [0c5d862f] log:
 ├─possible versions are: 0.1.0-5.16.1 or uninstalled
 ├─restricted to versions 5.16.0-5 by StructuralIdentifiability [220ca800], leaving only versions: 5.16.0-5.16.1 or uninstalled      
 │ └─StructuralIdentifiability [220ca800] log:
 │   ├─possible versions are: 0.5.1 or uninstalled
 │   └─StructuralIdentifiability [220ca800] is fixed to version 0.5.1
 ├─restricted by julia compatibility requirements to versions: 0.1.0-5.14.1 or uninstalled, leaving only versions: uninstalled       
 └─restricted by compatibility requirements with ModelingToolkit [961ee093] to versions: 5.7.0-5.16.1 — no versions left
   └─ModelingToolkit [961ee093] log:
     ├─possible versions are: 0.0.1-8.75.0 or uninstalled
     ├─restricted to versions 8.74.0-8 by StructuralIdentifiability [220ca800], leaving only versions: 8.74.0-8.75.0 or uninstalled  
     │ └─StructuralIdentifiability [220ca800] log: see above
     └─restricted to versions * by an explicit requirement, leaving only versions: 8.74.0-8.75.0

UPD:

(si-1.9) pkg> st
Status `C:\data\projects\SI2\si-1.9\Project.toml`
  [961ee093] ModelingToolkit v8.75.0

pogudingleb commented 7 months ago

I seem to have some issues with dependencies on 1.9.4:

(si-1.9) pkg> add ModelingToolkit
(si-1.9) pkg> dev .
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package Symbolics [0c5d862f]:
 Symbolics [0c5d862f] log:
 ├─possible versions are: 0.1.0-5.16.1 or uninstalled
 ├─restricted to versions 5.16.0-5 by StructuralIdentifiability [220ca800], leaving only versions: 5.16.0-5.16.1 or uninstalled      
 │ └─StructuralIdentifiability [220ca800] log:
 │   ├─possible versions are: 0.5.1 or uninstalled
 │   └─StructuralIdentifiability [220ca800] is fixed to version 0.5.1
 ├─restricted by julia compatibility requirements to versions: 0.1.0-5.14.1 or uninstalled, leaving only versions: uninstalled       
 └─restricted by compatibility requirements with ModelingToolkit [961ee093] to versions: 5.7.0-5.16.1 — no versions left
   └─ModelingToolkit [961ee093] log:
     ├─possible versions are: 0.0.1-8.75.0 or uninstalled
     ├─restricted to versions 8.74.0-8 by StructuralIdentifiability [220ca800], leaving only versions: 8.74.0-8.75.0 or uninstalled  
     │ └─StructuralIdentifiability [220ca800] log: see above
     └─restricted to versions * by an explicit requirement, leaving only versions: 8.74.0-8.75.0

UPD:

(si-1.9) pkg> st
Status `C:\data\projects\SI2\si-1.9\Project.toml`
  [961ee093] ModelingToolkit v8.75.0

Yes, the necessary version of Symbolics requires Julia 1.10, so the extension will not work on lower versions. I am not sure if there is anything I can do with this

SciML / StructuralIdentifiability.jl

Render ModelingToolkit as an extension #266

Codecov Report