search

SciML / StructuralIdentifiability.jl

Fast and automatic structural identifiability software for ODE systems
https://docs.sciml.ai/StructuralIdentifiability/stable/
MIT License
109 stars 17 forks source link

Bump the symbolic libraries and fix deprecations #327

Closed ChrisRackauckas closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.10%. Comparing base (0331ee9) to head (06f2084).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #327 +/- ## ========================================== + Coverage 87.32% 90.10% +2.77% ========================================== Files 28 28 Lines 3314 3314 ========================================== + Hits 2894 2986 +92 + Misses 420 328 -92 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pogudingleb commented 3 months ago

This PR was not passing CI, so I reopened it. @ChrisRackauckas I would greatly appreciate if PRs which change the code (not only compats) are merged after I look at them.

Thanks for fixing the depreciation!

ChrisRackauckas commented 3 months ago

This PR passed all tests? And it was just a depwarn fix?

pogudingleb commented 3 months ago

This PR passed all tests? And it was just a depwarn fix?

Yes, you can say so: it was failing "Downgrade" test because of the devs inconsistency

ChrisRackauckas commented 3 months ago

Downgrade CI currently has some false negatives because it needs a different resolver, which will hopefully be something added in the next few months.

pogudingleb commented 3 months ago

Glad to hear about these developments in Downgrade. In this case, it actually spotted a mismatch, I have fixed it anyway.