Update gekpls.md using LHS Sampling

SciML / Surrogates.jl

Surrogate modeling and optimization for scientific machine learning (SciML)

https://docs.sciml.ai/Surrogates/stable/

Other

323 stars 69 forks source link

Update gekpls.md using LHS Sampling #455

Closed Spinachboul closed 7 months ago

Spinachboul commented 7 months ago

Checklist

[x] Appropriate tests were added
[x] Any code changes were done in a way that does not break public API
[x] All documentation related to code changes were updated
[x] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[x] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (aa744e5) 78.12% compared to head (56f1f3e) 78.12%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #455 +/- ## ======================================= Coverage 78.12% 78.12% ======================================= Files 23 23 Lines 3154 3154 ======================================= Hits 2464 2464 Misses 690 690 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Spinachboul commented 7 months ago

@sathvikbhagavan I apologize if my intention for using lhs was not clear! Lhs lets you sample data points in different dimensions with uniformity, so for a function like gekpls, I thought sampling points with more expanded space would give better accuracy. I will surely test rmse for all the functions and then reach a proper conclusion.

And I will follow the same tutorial pattern for any changes in the future since I have just started contributing.

Thanks for the feedback!!