search

SciML / Surrogates.jl

Surrogate modeling and optimization for scientific machine learning (SciML)
https://docs.sciml.ai/Surrogates/stable/
Other
330 stars 69 forks source link

More CI #458

Closed ArnoStrouwen closed 9 months ago

ArnoStrouwen commented 9 months ago

Not sure what to do with the piracy https://github.com/SciML/Surrogates.jl/blob/master/src/Radials.jl#L4

ChrisRackauckas commented 9 months ago

Define an _copy function and use it in that file.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa744e5) 78.12% compared to head (3fd8d0b) 78.12%.

Files Patch % Lines
src/Radials.jl 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #458 +/- ## ======================================= Coverage 78.12% 78.12% ======================================= Files 23 23 Lines 3154 3155 +1 ======================================= + Hits 2464 2465 +1 Misses 690 690 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ArnoStrouwen commented 9 months ago

I was hoping that with the standard libraries compat changes it would be possible to run CI on Julia 1.10 with e.g. LinearAlgebra on 1.9, but this seems not to be the case: https://github.com/SciML/Surrogates.jl/actions/runs/7348928232/job/20007931762?pr=458#step:5:47 @ChrisRackauckas how do you want to handle downgrade CI then? Either we bump everything to 1.10, or we ignore the standard libraries.

ChrisRackauckas commented 9 months ago

I want to bump all libraries and CI to v1.10. I guess we can start here.

ArnoStrouwen commented 9 months ago

The downgrade CI is already bearing fruits, it found that in Julia 1.10 you need the very recent Zygote = "0.6.62".