Closed ArnoStrouwen closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b66096e
) 78.00% compared to head (d1c7321
) 78.12%. Report is 4 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@oxinabox do you know if these method ambiguities are something to worry about? And how to best fix them? https://github.com/SciML/Surrogates.jl/actions/runs/7435983790/job/20231942821?pr=462#step:6:833
Looks like a bug in ChainRulesCore. I don't understand why they are only showing up recently. There is nothing for you to do about them here. I will open a PR presently to fix them in ChainRulesCore
@sathvikbhagavan I don't see this error locally. Is this another stochastic result? https://github.com/SciML/Surrogates.jl/actions/runs/7498946122/job/20414889506?pr=462#step:6:1897
@sathvikbhagavan I don't see this error locally. Is this another stochastic result? SciML/Surrogates.jl/actions/runs/7498946122/job/20414889506?pr=462#step:6:1897
Yes, it is indeed stochastic. It happens because one of the test cluster which is sampled contains no points.
I was thinking of fixing it such that if any test cluster is empty, it uses training points for obtaining the best model for that cluster. I will make a PR for it shortly.
@ChrisRackauckas, I think this is ready. The remaining stochastic error should be looked into separately.
@nograd
is being deprecated. However, seems strange, this needs to be non-differentiable in any case?