SciML / Surrogates.jl

Surrogate modeling and optimization for scientific machine learning (SciML)
https://docs.sciml.ai/Surrogates/stable/
Other
330 stars 69 forks source link

fix deprecation warning #462

Closed ArnoStrouwen closed 8 months ago

ArnoStrouwen commented 9 months ago

@nograd is being deprecated. However, seems strange, this needs to be non-differentiable in any case?

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b66096e) 78.00% compared to head (d1c7321) 78.12%. Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #462 +/- ## ========================================== + Coverage 78.00% 78.12% +0.12% ========================================== Files 23 23 Lines 3155 3155 ========================================== + Hits 2461 2465 +4 + Misses 694 690 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ArnoStrouwen commented 9 months ago

@oxinabox do you know if these method ambiguities are something to worry about? And how to best fix them? https://github.com/SciML/Surrogates.jl/actions/runs/7435983790/job/20231942821?pr=462#step:6:833

oxinabox commented 9 months ago

Looks like a bug in ChainRulesCore. I don't understand why they are only showing up recently. There is nothing for you to do about them here. I will open a PR presently to fix them in ChainRulesCore

ArnoStrouwen commented 8 months ago

@sathvikbhagavan I don't see this error locally. Is this another stochastic result? https://github.com/SciML/Surrogates.jl/actions/runs/7498946122/job/20414889506?pr=462#step:6:1897

sathvikbhagavan commented 8 months ago

@sathvikbhagavan I don't see this error locally. Is this another stochastic result? SciML/Surrogates.jl/actions/runs/7498946122/job/20414889506?pr=462#step:6:1897

Yes, it is indeed stochastic. It happens because one of the test cluster which is sampled contains no points.

sathvikbhagavan commented 8 months ago

I was thinking of fixing it such that if any test cluster is empty, it uses training points for obtaining the best model for that cluster. I will make a PR for it shortly.

ArnoStrouwen commented 8 months ago

@ChrisRackauckas, I think this is ready. The remaining stochastic error should be looked into separately.