Closed Spinachboul closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b66096e
) 78.00% compared to head (af820a3
) 78.12%. Report is 11 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@sathvikbhagavan and @ChrisRackauckas Have you gone through the explanation and also the PR??
For the benchmarks, I was thinking each benchmark problem should have three sections:
Can you do the same for tensor product
benchmark?
As for the Kriging
, please open a separate PR and edit the explanations in the tutorials. It will be easier to see the changes.
@sathvikbhagavan.
Could you please look into the PR
I have made the changes in tensor_prod
benchmark
@ChrisRackauckas and @sathvikbhagavan Please have a look, at this PR. I have used 5 models for benchmark tensor product function
@ChrisRackauckas just to clarify, should we have benchmarks section in Surrogates documentation or completely move them to SciMLBenchmarks?
Yes, we should make a new surrogates section
I have made a new PR for the previous change. This is just changing the tensor_prod function in a more readable form which I think I, @ChrisRackauckas and @sathvikbhagavan agreed. Kindly please review it for merging.
Next I am working on explaining the mathematical concepts for Kriging and other surrogate models. I already gave a sample explaination for Kriging and asked if we could go with the same format. So in future I will hit a draft PR where I will constantly modify the tutorials section.
Well this is the explaination for Kriging: