search

SciML / Surrogates.jl

Surrogate modeling and optimization for scientific machine learning (SciML)
https://docs.sciml.ai/Surrogates/stable/
Other
323 stars 69 forks source link

refactor: SurrogatesRandomForest with SurrogatesBase #477

Closed sathvikbhagavan closed 4 months ago

sathvikbhagavan commented 4 months ago

Next in line after https://github.com/SciML/Surrogates.jl/pull/475

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 65.83%. Comparing base (26b5705) to head (a20c8d5).

Files Patch % Lines
...rrogatesRandomForest/src/SurrogatesRandomForest.jl 0.00% 14 Missing :warning:
lib/SurrogatesSVM/src/SurrogatesSVM.jl 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #477 +/- ## =========================================== - Coverage 78.22% 65.83% -12.40% =========================================== Files 23 23 Lines 3136 3108 -28 =========================================== - Hits 2453 2046 -407 - Misses 683 1062 +379 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 4 months ago

The doc build failure looks real?

sathvikbhagavan commented 4 months ago

Yeah, it is because surrogate_optimize takes in AbstractSurrogate defined in Surrogates.jl but SurrogatesRandomForest now uses type from SurrogatesBase.jl. I think it should be fine for now. My plan is to refactor the remaining subpackages first and then I will fix surrogate_optimize and docs. Does that sound ok?

ChrisRackauckas commented 4 months ago

yes