Closed AayushSabharwal closed 7 months ago
Attention: Patch coverage is 5.26316%
with 36 lines
in your changes are missing coverage. Please review.
Project coverage is 34.03%. Comparing base (
2a45e9c
) to head (7713bc0
).
Files | Patch % | Lines |
---|---|---|
src/symbol_cache.jl | 6.89% | 27 Missing :warning: |
src/trait.jl | 0.00% | 8 Missing :warning: |
src/interface.jl | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Does the spec says what should be used as keys or is it up to the package that implements this?
All SII can say is that the keys are symbolic variables. Whether that's Num
, Symbol
, BasicSymbolic
or something else is up to the implementation, since SII
does not know of these
Right now it's somewhat arbitrary. I don't think we'll need it to be mutable in remake or anywhere else, but you mentioned that we should standardize it and mutability offers us more flexibility in the future.
Yeah, it's nicer if it's mutable, that makes it easier in certain situations.
Checklist
Additional context
Add any other context about the problem here.