SciML / SymbolicIndexingInterface.jl

A general interface for symbolic indexing of SciML objects used in conjunction with Domain-Specific Languages
https://docs.sciml.ai/SymbolicIndexingInterface/stable/
MIT License
15 stars 8 forks source link

feat: add `default_values` to interface #47

Closed AayushSabharwal closed 7 months ago

AayushSabharwal commented 8 months ago

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 5.26316% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 34.03%. Comparing base (2a45e9c) to head (7713bc0).

Files Patch % Lines
src/symbol_cache.jl 6.89% 27 Missing :warning:
src/trait.jl 0.00% 8 Missing :warning:
src/interface.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #47 +/- ## ========================================== - Coverage 38.17% 34.03% -4.14% ========================================== Files 7 7 Lines 296 332 +36 ========================================== Hits 113 113 - Misses 183 219 +36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AayushSabharwal commented 7 months ago

Does the spec says what should be used as keys or is it up to the package that implements this?

All SII can say is that the keys are symbolic variables. Whether that's Num, Symbol, BasicSymbolic or something else is up to the implementation, since SII does not know of these

AayushSabharwal commented 7 months ago

Right now it's somewhat arbitrary. I don't think we'll need it to be mutable in remake or anywhere else, but you mentioned that we should standardize it and mutability offers us more flexibility in the future.

SebastianM-C commented 7 months ago

Yeah, it's nicer if it's mutable, that makes it easier in certain situations.