SciML / SymbolicIndexingInterface.jl

A general interface for symbolic indexing of SciML objects used in conjunction with Domain-Specific Languages
https://docs.sciml.ai/SymbolicIndexingInterface/stable/
MIT License
14 stars 6 forks source link

feat: support indexing Tuple parameters, add tests #63

Closed AayushSabharwal closed 5 months ago

AayushSabharwal commented 5 months ago

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (ed4bce0) to head (30b4759).

Files Patch % Lines
src/remake.jl 0.00% 10 Missing :warning:
src/parameter_indexing.jl 0.00% 3 Missing :warning:
src/trait.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #63 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 7 7 Lines 355 366 +11 ====================================== - Misses 355 366 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SebastianM-C commented 5 months ago

When would one want to use Tuple indexing? Would that be used in conjunction with MTKParameters?

AayushSabharwal commented 5 months ago

No, just allowing the parameter object to be a Tuple: ODEProblem(fn, u0, tspan, (1.0, 2.0, 3.0))

ChrisRackauckas commented 5 months ago

Let's follow up with the performance bit if it's needed.

AayushSabharwal commented 5 months ago

This can't really be fully inferred, since

  1. The dict in the last argument is not concrete
  2. The type of the buffer can change
ChrisRackauckas commented 5 months ago

Gotcha