SciML / SymbolicIndexingInterface.jl

A general interface for symbolic indexing of SciML objects used in conjunction with Domain-Specific Languages
https://docs.sciml.ai/SymbolicIndexingInterface/stable/
MIT License
15 stars 8 forks source link

feat: add `is_parameter_timeseries` trait, improve parameter timeseries indexing #75

Closed AayushSabharwal closed 4 months ago

AayushSabharwal commented 5 months ago

Checklist

Additional context

Add any other context about the problem here.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 94.08784% with 35 lines in your changes missing coverage. Please review.

Project coverage is 92.82%. Comparing base (c9c7b6c) to head (7b26af0).

Files Patch % Lines
src/parameter_indexing.jl 93.04% 19 Missing :warning:
src/value_provider_interface.jl 75.86% 14 Missing :warning:
src/index_provider_interface.jl 92.85% 1 Missing :warning:
src/state_indexing.jl 98.61% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #75 +/- ## =========================================== + Coverage 28.07% 92.82% +64.75% =========================================== Files 11 12 +1 Lines 513 1018 +505 =========================================== + Hits 144 945 +801 + Misses 369 73 -296 ``` | [Flag](https://app.codecov.io/gh/SciML/SymbolicIndexingInterface.jl/pull/75/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciML) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/SciML/SymbolicIndexingInterface.jl/pull/75/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciML) | `34.95% <35.36%> (+6.88%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SciML#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AayushSabharwal commented 4 months ago

I'll reopen to run CI once MTK and SciMLBase are tagged (closed it a bit prematurely)

AayushSabharwal commented 4 months ago

RAT downstream failure is an adjoint bug in SciMLBase

AayushSabharwal commented 4 months ago

SciMLBase downstream failure is an MTK bug