check dimensions for multiple setters

SciML / SymbolicIndexingInterface.jl

A general interface for symbolic indexing of SciML objects used in conjunction with Domain-Specific Languages

MIT License

15 stars 8 forks source link

Open hexaeder opened 4 months ago

hexaeder commented 4 months ago

[x] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[x] All documentation related to code changes were updated
[x] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[x] Any new documentation only uses public API

fixes #82

Technically breaking? But I personally would consider the old behaviour a bug.

hexaeder commented 4 months ago

Instead of changing from map to broadcast, it would also be fine to check the sizes explicitly

if size(ms.setters) != size(val)
    throw(DimensionMismatch("Cannot set variables of size $(size(ms.setters)) to values of size $(size(val))."))
end

My point about the bug is the silent dropping of setters/values rather than the missing broadcast behavior.