Closed hexaeder closed 3 weeks ago
Same problem seems to apply to appear with get_all_timeseries_indexes
now to.
Thanks for pointing this out, #90 should fix this
Thanks for the fix, unfortunately the problem still pops up, now in a method in SciMLBase
.
However I removed the symbolic_container(inpr::MyIndPr) = inpr
definition and everything it seems to work. Maybe this should be reflected in the symbolic_container
docstring, that the method should not be implemented for types implementing the interface...
Yeah that does seem like the better approach. It is technically breaking, but we should be able to get away with it.
Describe the bug 🐞
According to the docs, you should define
in case
MyIndexProvider
implements the interface:https://github.com/SciML/SymbolicIndexingInterface.jl/blob/e7dd822c3dd5aa60161f77e6e96a32ce5c4941bb/src/index_provider_interface.jl#L2-L7
However, this leads to a stack overflow in the default implementation of
is_timeseries_parameter
https://github.com/SciML/SymbolicIndexingInterface.jl/blob/e7dd822c3dd5aa60161f77e6e96a32ce5c4941bb/src/index_provider_interface.jl#L61-L67
as it descents forever as long as the
symbolic_container
method exists.The docs do not mention any new methods to implement to fulfill the index provider interface.