search

SciNim / getting-started

Getting started with Nim for Scientific Computing
https://scinim.github.io/getting-started/
Creative Commons Zero v1.0 Universal
61 stars 6 forks source link

Unchained Tutorial #30

Closed HugoGranstrom closed 3 years ago

HugoGranstrom commented 3 years ago

Mainly wanted to check that the CI still worked 🙃 I'm not done yet, but I'm starting to run out of ideas. @Vindaar anything important you feel is missing? 😅

Vindaar commented 3 years ago

Awesome! I'll check it out tomorrow. 😃

HugoGranstrom commented 3 years ago

Awesome! I'll check it out tomorrow. 😃

Thank you! 😄 I'll see if I can get the preview working until then 🤣

HugoGranstrom commented 3 years ago

Aside from my minor remarks I really like it!

Two things one could maybe add:

* explicitly mention that products of different quantities are allowed, but additions are not (as one should expect)

* add a note about how maths between same quantities of different units (and specifically different SI prefixes) is handled (conversion to SI base units).

I've added a section on unit arithmetic now. I'm not really pleased with the final example though so I'll tinker with it a bit tomorrow. But the text should be ready for review. I hope I got the list complete 🙃

HugoGranstrom commented 3 years ago

@Vindaar Thanks for the fix to Unchained :D If the CI passes I think we are ready for a merge?

Vindaar commented 3 years ago

@Vindaar Thanks for the fix to Unchained :D If the CI passes I think we are ready for a merge?

Yup, aside from that one comment I overlooked, it's fine to merge.