search

SciNim / nim-plotly

plotly wrapper for nim-lang
https://scinim.github.io/nim-plotly/
MIT License
179 stars 15 forks source link

Implement basic support for Candlestick PlotType #14

Closed durdn closed 6 years ago

durdn commented 6 years ago

With your helpful hints I got the very basics of the Candlestick PlotType to work. Thanks a lot!

durdn commented 6 years ago

I also added support to turn off the rangeslider which is incredibly annoying for me ;)

durdn commented 6 years ago

I updated the code. It works with the quote sigil (but I'll be honest I'm travelling so I redid everything from my Mac). Cheers!

brentp commented 6 years ago

cheers!

@Vindaar I don't like the conflict with low, high, close either, but I think matching the JSON output makes things more transparent.

Araq commented 6 years ago

Simply because they are also keywords in Nim.

They really are not.

Vindaar commented 6 years ago

@Araq Oh, then I got fooled by nim-mode. They're all highlighted, so that's where my guess came from. Thank's for clarifying. Were they at some point in the past?

Araq commented 6 years ago

No, the real keywords can be found here: https://nim-lang.org/docs/manual.html#lexical-analysis-identifiers-keywords

And this list is actually shrinking more often than growing.

Vindaar commented 6 years ago

Thanks. I know the list, but didn't check for these, hehe.

Yup, since it's shrinking I was wondering, whether it's a thing of the past in nim-mode.

Anyway, enough off topic here. :)