Legend font plus two bugfixes

Vindaar commented 5 years ago

I accidentally sat on these changes on my local PC for months now and only realized now I never committed them.

This PR adds a font field to the Legend so that one can change the size / color / family of the Legend font.

And also fixes two stupid bugs of mine that would have been caught had I written tests for the sugar submodule. Sorry about that.

brentp commented 5 years ago

do you know what happened with travis? must be a change on their setup, unrelated to this.

Vindaar commented 5 years ago

Not sure what happened with travis. I'll see what I can do about it.

Vindaar commented 5 years ago

NOTE: the last commit is NOT ready to be merged! I need to clean stuff up and change some things here and there. Will probably only do that tomorrow though.

edit: also squash and force push away all those stupid commits (:

Vindaar commented 5 years ago

Ok, I just cleaned up that commit history.

I decided to change the following things:

we now test against both the latest Nim stable and devel
travis now uses webview to save images. I don't understand what's wrong with the previous approach to save images on travis and I'm not willing to waste anymore time to figure this out. Debugging travis is a pain.
if travis uses webview or the user calls saveImage with the webview target, the webview window is automatically closed again after the file was successfully saved. This way there is a (strings attached...) way to automatically save many plots without as many tabs in a browser at least.

If this sounds reasonable I consider this ready to be merged.

brentp commented 5 years ago

cheers!

SciNim / nim-plotly

Legend font plus two bugfixes #46