search

SciNim / nim-plotly

plotly wrapper for nim-lang
https://scinim.github.io/nim-plotly/
MIT License
179 stars 15 forks source link

fix error message for websocket fail #60

Closed Vindaar closed 4 years ago

Vindaar commented 4 years ago

Seems like something changed in the either in the stdlib regarding printing of enums or error here simply wasn't an enum in the websocket library before?

Vindaar commented 4 years ago

Now that's another fun travis error. Now I don't know whether it's because opening the browser blocked the thread again or if that weird 

** (fig12_save_figure:22595): WARNING **: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files

error is actually the cause. :|

edit: welp, installing the package got rid of the warning/error, but that's not the real problem. Seems like firefox is blocking again.

Vindaar commented 4 years ago

Ok, I don't have the nerve to try debugging travis right now. I'll take a look tomorrow.

Vindaar commented 4 years ago

Wow, using @treeform's websocket library it passes fine. I tried that because it also didn't work for me locally anymore.

@brentp What's your opinion? Should we switch the websocket library we use? I guess I could try to understand why the current websocket library suddenly just blocks. The await ws.readData() call just blocks indefinitely for me.

treeform commented 4 years ago

If you need help with my ws lib I am around.

Vindaar commented 4 years ago

Can you hop on discord?

Vindaar commented 4 years ago

Ok, after chatting with @treeform I decided to switch over to his library. Let me know if you're ok with that, @brentp.

edit: I would propose to push version v0.3.0 once this PR and a follow up (for WSL support which I'm going to push in a few minutes) is merged.

brentp commented 4 years ago

yes, @Vindaar that is fine with me. (As you know) you wrote all that code anyway. :)

Vindaar commented 4 years ago

This PR can be merged as far as I'm concerned. Not sure what the 

continuous-integration/travis-ci Expected — Waiting for status to be reported

is trying to tell me though.