search

SciNim / nim-plotly

plotly wrapper for nim-lang
https://scinim.github.io/nim-plotly/
MIT License
173 stars 15 forks source link

plotly breaks nim CI #67

Closed timotheecour closed 3 years ago

timotheecour commented 3 years ago

refs https://github.com/nim-lang/Nim/issues/16419

timotheecour commented 3 years ago

@brentp out of curiosity how come did nim-plotly's CI did not catch this before the merge?

brentp commented 3 years ago

travis-ci no longer works for free projects. https://news.ycombinator.com/item?id=25338983

(is that what you mean?)

ringabout commented 3 years ago

Last CI run at 17 Oct, then I guess that chroma didn't have breaking changes then.

Vindaar commented 3 years ago

then I guess that chroma didn't have breaking changes then.

chroma did have a breaking change! https://github.com/treeform/chroma/commit/91f76f6782549b3a804f18d3b36cc108719986df

Which tbf is partly my fault, cause I didn't get into looking into the performance regression in chroma.