Continuation of #39 (resizing, temp files)

SciNim / nim-plotly

plotly wrapper for nim-lang

https://scinim.github.io/nim-plotly/

MIT License

179 stars 15 forks source link

Continuation of #39 (resizing, temp files) #72

Closed Vindaar closed 2 years ago

Vindaar commented 2 years ago

This is a rebase and continuation of #39.

The main differences being:

auto resizing of the plot is an argument to the different procedures. For saveImage by default it is false (to keep the sizes) and for show it is true
make the names for some arguments clearer (in particular path) to hand a custom path for the generated HTML, which already allowed to overwrite the default /tmp/x.html
we generate a directory based on the given filename (if none then we use "nim_plotly" as a default) & the current date (in millisecond accuracy)
adds an option to remove the HTML files (by default false)
and some small fixes for the tests

Vindaar commented 2 years ago

LGTM

Thanks, but we still have this weird travis CI "Expected — Waiting for status to be reported". Only you can merge the PR at the moment I think.

brentp commented 2 years ago

SMH. I had been thinking no one was interested in using this. If they are, and more importantly, if you are doing most of the maintenance, perhaps it's a good time to move this repo to a different organization?

Vindaar commented 2 years ago

SMH. I had been thinking no one was interested in using this. If they are, and more importantly, if you are doing most of the maintenance, perhaps it's a good time to move this repo to a different organization?

If you wish we could just move it under the SciNim org?

brentp commented 2 years ago

If you wish we could just move it under the SciNim org?

Yes, let's do it.

Vindaar commented 2 years ago

If you wish we could just move it under the SciNim org?

Yes, let's do it.

You will just have to do the transfer yourself as the owner. Settings ⇒ scroll to bottom ⇒ transfer

brentp commented 2 years ago

done!