Implement `Offline` assets providing type

SciProgCentre / plotly.kt

An interactive Kotlin wrapper for plotly visualization tools

https://sciprogcentre.github.io/plotly.kt/

Apache License 2.0

149 stars 21 forks source link

Implement `Offline` assets providing type #25

Closed dector closed 3 years ago

dector commented 4 years ago

This is follow-up issue for #24.

Offline mode means that assets will be downloaded, stored in a separate folder and referenced from HTML files using relative path.

altavir commented 4 years ago

Thanks a lot! I will review it ASAP.

altavir commented 4 years ago

It seems like plotly for python does it the same way: https://github.com/plotly/plotly.py/blob/8bf3d5e8bfc212e4df486136d00ba109c78c3945/packages/python/plotly/plotly/offline/offline.py#L459

altavir commented 4 years ago

Mostly done via 1531db288309289a870515d66a31dc5e79591195. Needs to be documented though. Currently, it works for HTML headers. I don't know if we need it for other assets.

altavir commented 3 years ago

@dector Should we close this? The solution right now is much more narrow than the one, you proposed. Should we expand custom content support?

dector commented 3 years ago

I agree. We can do this later if needed.