Closed jeandet closed 3 years ago
Merging #14 (b58483a) into main (3a9c66d) will decrease coverage by
5.58%
. The diff coverage is62.53%
.
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 80.60% 75.02% -5.59%
==========================================
Files 18 24 +6
Lines 825 1085 +260
Branches 139 185 +46
==========================================
+ Hits 665 814 +149
- Misses 128 232 +104
- Partials 32 39 +7
Flag | Coverage Δ | |
---|---|---|
unittests | 75.02% <62.53%> (-5.59%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
speasy/common/variable.py | 90.10% <ø> (ø) |
|
speasy/config/exceptions.py | 42.85% <42.85%> (ø) |
|
speasy/amda/amda.py | 57.39% <45.80%> (-26.35%) |
:arrow_down: |
speasy/amda/utils.py | 69.35% <69.35%> (ø) |
|
speasy/amda/rest.py | 76.47% <75.71%> (+0.60%) |
:arrow_up: |
speasy/amda/__init__.py | 100.00% <100.00%> (ø) |
|
speasy/amda/dataset.py | 100.00% <100.00%> (ø) |
|
speasy/amda/inventory.py | 100.00% <100.00%> (ø) |
|
speasy/amda/parameter.py | 100.00% <100.00%> (ø) |
|
speasy/amda/timetable.py | 100.00% <100.00%> (ø) |
|
... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ddb5a71...b58483a. Read the comment docs.
Looks good to me. Concerning the data's time range I agree that the last date should not be included in the data. For now that's not the way AMDA deals with the requests, we can always remove the last rows from the data before returning the SpeasyVariable object.