SciQLop / speasy

Space Physics made EASY! A simple Python package to deal with main Space Physics WebServices (CDA,SSC,AMDA,..)
Other
24 stars 7 forks source link

Timetable and catalogs refactoring #15

Closed jeandet closed 3 years ago

jeandet commented 3 years ago

This PR is not complete yet, the idea is to:

codecov[bot] commented 3 years ago

Codecov Report

Merging #15 (349fb17) into main (3a9c66d) will decrease coverage by 5.71%. The diff coverage is 63.93%.

:exclamation: Current head 349fb17 differs from pull request most recent head 251a765. Consider uploading reports for the commit 251a765 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   80.60%   74.88%   -5.72%     
==========================================
  Files          18       25       +7     
  Lines         825     1111     +286     
  Branches      139      187      +48     
==========================================
+ Hits          665      832     +167     
- Misses        128      239     +111     
- Partials       32       40       +8     
Flag Coverage Δ
unittests 74.88% <63.93%> (-5.72%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
speasy/common/variable.py 90.10% <ø> (ø)
speasy/config/exceptions.py 42.85% <42.85%> (ø)
speasy/amda/amda.py 56.81% <47.82%> (-26.93%) :arrow_down:
speasy/amda/utils.py 69.35% <69.35%> (ø)
speasy/amda/indexes.py 73.33% <73.33%> (ø)
speasy/amda/rest.py 76.47% <75.71%> (+0.60%) :arrow_up:
speasy/amda/__init__.py 100.00% <100.00%> (ø)
speasy/amda/dataset.py 100.00% <100.00%> (ø)
speasy/amda/inventory.py 100.00% <100.00%> (ø)
speasy/amda/parameter.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ddb5a71...251a765. Read the comment docs.

lgtm-com[bot] commented 3 years ago

This pull request introduces 3 alerts when merging 9ba8d4e70a400be5c2980d1a01936fb72c8d7d7d into ddb5a71dc0bb5dc66465c00a5ddaf79b7f6d3db0 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 6 when merging 682986b3a2610aa7dba2d428fe3720aed29b00d0 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

fixed alerts:

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 6 when merging 349fb17161b8d35312f32b9276affd5136189268 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

fixed alerts: