jeandet commented 3 years ago

This PR is not complete yet, the idea is to:

make Timetable and Catalogs related objects as much as possible user friendly with nice repr and UX
move Timetable and Catalog object to speazy.common with a dedicated UX which is different from SpeasyVariable
remove unnecessary code
unify API across providers

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 8 when merging cbd7eb6ca6574901c90f046bc01e9323c710d6ec into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information

fixed alerts:

8 for Unused import

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 9 when merging c41b38109b977c88f1cdf457c1c3abdd4c216ad0 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information

fixed alerts:

8 for Unused import
1 for Module is imported more than once

codecov[bot] commented 3 years ago

Codecov Report

Merging #17 (6754c81) into main (e107171) will increase coverage by 9.94%. The diff coverage is 87.75%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   75.02%   84.96%   +9.94%     
==========================================
  Files          24       31       +7     
  Lines        1085     1450     +365     
  Branches      185      207      +22     
==========================================
+ Hits          814     1232     +418     
+ Misses        232      156      -76     
- Partials       39       62      +23

Flag	Coverage Δ
unittests	`84.96% <87.75%> (+9.94%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
speasy/core/cache/version.py	`100.00% <ø> (ø)`
speasy/core/span_utils.py	`86.44% <ø> (ø)`
speasy/webservices/amda/_impl.py	`72.04% <72.04%> (ø)`
speasy/webservices/amda/rest_client.py	`75.28% <75.28%> (ø)`
speasy/core/datetime_range.py	`83.72% <83.72%> (ø)`
speasy/webservices/cda/__init__.py	`46.00% <85.71%> (ø)`
speasy/inventory/indexes.py	`86.11% <86.11%> (ø)`
speasy/webservices/amda/ws.py	`86.11% <86.11%> (ø)`
speasy/products/dataset.py	`87.87% <87.87%> (ø)`
speasy/core/__init__.py	`89.28% <89.28%> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e107171...6754c81. Read the comment docs.

lgtm-com[bot] commented 3 years ago

This pull request introduces 10 alerts and fixes 10 when merging 12a2173b3b80e054c5d4063bb864d413a171e85c into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information
1 for `__eq__` not overridden when adding attributes
1 for Unused import

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable

lgtm-com[bot] commented 3 years ago

This pull request introduces 9 alerts and fixes 10 when merging a64ccc4b3f806ee4e97e510879f8726c150b1656 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information
1 for `__eq__` not overridden when adding attributes

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable

lgtm-com[bot] commented 3 years ago

This pull request introduces 9 alerts and fixes 10 when merging ab932ee78d1bc5b6abf8deb5bf31720f5922f363 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information
1 for `__eq__` not overridden when adding attributes

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 10 when merging 423b0b5627cc1c8f0417516dc54003da80f812d3 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 10 when merging 22b47d7cbe0bbad84745ace200d4e2d3b3a78572 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 11 when merging 20f3cf784a89114de33d538c086a64a7df83495d into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 11 when merging 35bc3f40bdcb3b06fbae3eb84d5ba7e3dc3c4256 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 11 when merging 58fddcb569928a3c1a929516f3fcea16302b73bc into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

8 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 11 when merging 7e9507d109bedc8af88d8e5dc636b3606a09fa69 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

7 for Clear-text logging of sensitive information
1 for Unused import

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace

lgtm-com[bot] commented 3 years ago

This pull request introduces 8 alerts and fixes 12 when merging 4ab139c20025a1f22e24a10094b3508f61ca4d9d into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

7 for Clear-text logging of sensitive information
1 for Unused import

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 3 years ago

This pull request introduces 7 alerts and fixes 12 when merging 4e0b66786e657990c1725c2cc89868459c8a3641 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

7 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 3 years ago

This pull request introduces 7 alerts and fixes 12 when merging 79749fc3fd5919fc7abcd1b4a6cd4c7c6bc88aa2 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

7 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 3 years ago

This pull request introduces 7 alerts and fixes 12 when merging 2067e3c8de216c2cc7b0660ca30b609f8da40f28 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

7 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 3 years ago

This pull request introduces 7 alerts and fixes 12 when merging 86d746b549d151846f9f2035981f09013a84a1ba into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

7 for Clear-text logging of sensitive information

fixed alerts:

7 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 3 years ago

This pull request introduces 10 alerts and fixes 18 when merging 80bfdbddd3cf45bd1165392de828fc64376baf37 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

5 for Conflicting attributes in base classes
3 for Unused import
1 for Wrong name for an argument in a call
1 for Unused local variable

fixed alerts:

13 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts and fixes 18 when merging 7e274c94b0f89de7e821c5dd2fdfc2f61f94678b into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

5 for Conflicting attributes in base classes
3 for Unused import
1 for Wrong name for an argument in a call
1 for Unused local variable

fixed alerts:

13 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 10 alerts and fixes 19 when merging 637ce688ace02bbdebc5163618fd5ceda84bcec6 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

5 for Conflicting attributes in base classes
3 for Unused import
1 for Wrong name for an argument in a call
1 for Unused local variable

fixed alerts:

13 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for Modification of parameter with default
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 7 alerts and fixes 19 when merging c2d5e21073cd03851738a573a4d508ae5153ba0a into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

5 for Conflicting attributes in base classes
1 for Wrong name for an argument in a call
1 for Unused import

fixed alerts:

13 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for Modification of parameter with default
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 6 alerts and fixes 19 when merging 6754c81fc1d149045870e8eda2b0d3bba7863fa5 into e107171bcb29b0ed81389cc0c2f3b9670e37d516 - view on LGTM.com

new alerts:

5 for Conflicting attributes in base classes
1 for Unused import

fixed alerts:

13 for Unused import
2 for Module is imported more than once
1 for Unused local variable
1 for Modification of parameter with default
1 for 'import *' may pollute namespace
1 for Clear-text logging of sensitive information

jeandet commented 2 years ago

Let's merge this huge PR and switch to a smaller/saner PRs. Closes #18

SciQLop / speasy

Amda refac and some global refac #17

Codecov Report