SciQLop / speasy

Space Physics made EASY! A simple Python package to deal with main Space Physics WebServices (CDA,SSC,AMDA,..)
Other
24 stars 7 forks source link

Raises now if unknown kwargs are passed to get_data methods #22

Closed jeandet closed 2 years ago

jeandet commented 2 years ago

Fixes #19 Fixes #20

Removes also some libs that are not used anymore in requirements files.

codecov[bot] commented 2 years ago

Codecov Report

Merging #22 (6e2ae25) into main (ae058f3) will decrease coverage by 1.41%. The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   86.55%   85.13%   -1.42%     
==========================================
  Files          31       31              
  Lines        1450     1467      +17     
  Branches      207      209       +2     
==========================================
- Hits         1255     1249       -6     
- Misses        133      156      +23     
  Partials       62       62              
Flag Coverage Δ
unittests 85.13% <96.55%> (-1.42%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
speasy/webservices/amda/ws.py 86.20% <80.00%> (-1.99%) :arrow_down:
speasy/core/__init__.py 92.50% <100.00%> (-0.36%) :arrow_down:
speasy/core/cache/__init__.py 88.23% <100.00%> (+0.07%) :arrow_up:
speasy/core/proxy/__init__.py 91.17% <100.00%> (+0.26%) :arrow_up:
speasy/webservices/cda/__init__.py 46.53% <100.00%> (+0.53%) :arrow_up:
speasy/webservices/ssc/__init__.py 88.05% <100.00%> (+0.18%) :arrow_up:
speasy/webservices/amda/_impl.py 72.04% <0.00%> (-13.98%) :arrow_down:
speasy/webservices/amda/rest_client.py 75.28% <0.00%> (-6.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae058f3...6e2ae25. Read the comment docs.

jeandet commented 2 years ago

Il faudrait que je teste le code mais ça parait bien. Il ne faudrait pas reprendre les tests unitaires, surtout pour AMDA ?

C' est testé ici: https://github.com/SciQLop/speasy/pull/22/files#diff-ce314d833669e2857a4273f2a07906437f7e350473dfd66de3de8900e4d2930eR198