Closed Dolgalad closed 2 years ago
Merging #25 (b1b0b91) into main (78fa1b9) will decrease coverage by
1.20%
. The diff coverage is96.66%
.
@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 86.55% 85.34% -1.21%
==========================================
Files 31 31
Lines 1450 1467 +17
Branches 207 209 +2
==========================================
- Hits 1255 1252 -3
- Misses 133 153 +20
Partials 62 62
Flag | Coverage Δ | |
---|---|---|
unittests | 85.34% <96.66%> (-1.21%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
speasy/webservices/amda/ws.py | 86.20% <80.00%> (-1.99%) |
:arrow_down: |
speasy/core/__init__.py | 95.00% <100.00%> (+2.14%) |
:arrow_up: |
speasy/core/cache/__init__.py | 88.23% <100.00%> (+0.07%) |
:arrow_up: |
speasy/core/proxy/__init__.py | 91.17% <100.00%> (+0.26%) |
:arrow_up: |
speasy/webservices/amda/utils.py | 87.69% <100.00%> (ø) |
|
speasy/webservices/cda/__init__.py | 46.53% <100.00%> (+0.53%) |
:arrow_up: |
speasy/webservices/ssc/__init__.py | 88.05% <100.00%> (+0.18%) |
:arrow_up: |
speasy/webservices/amda/_impl.py | 72.04% <0.00%> (-13.98%) |
:arrow_down: |
speasy/webservices/amda/rest_client.py | 75.28% <0.00%> (-6.75%) |
:arrow_down: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 15ea87f...b1b0b91. Read the comment docs.
Can you add a test here https://github.com/SciQLop/speasy/blob/main/tests/test_amda.py#L53 ? I feel like we could easily forget this and introduce some regressions later.
Can you add a test here https://github.com/SciQLop/speasy/blob/main/tests/test_amda.py#L53 ? I feel like we could easily forget this and introduce some regressions later.
will do
Small fix for downloading multidimensional data from AMDA