SciQLop / tscat_gui

Time series catalogue - Graphical User Interface library
Other
4 stars 2 forks source link

Async poc #83

Closed pboettch closed 1 year ago

jeandet commented 1 year ago

This is way more responsive than before! I think there are few remaining issues:

pboettch commented 1 year ago

This is way more responsive than before! I think there are few remaining issues:

* When dragging an event into the trash I get `ValueError: badly formed hexadecimal UUID string`

* undo stack seems to do stuff in the wrong thread, undoing some operations gives: `sqlalchemy.exc.ProgrammingError: (sqlite3.ProgrammingError) SQLite objects created in a thread can only be used in that same thread. The object was created in thread id 140647421552448 and this is thread id 140646568531648.`

Could you explain which undo-action (What did you undo?) which gave this error?

jeandet commented 1 year ago

Not sure exactly it seems that interleaving drag and drop of events between catalogs and saves seems to generate the error quite easily. I think the undo error was also with a mixed stack of drag end drops deletes and saves.

jeandet commented 1 year ago

@pboettch were you able to reproduce the bug?

jeandet commented 1 year ago

Looks way better now, I also found that stats are not correctly updated on first catalog selection: