[WIP] Ports all IO modules from daru

SciRuby / daru-io

daru-io is a plugin gem to the existing daru gem, which aims to add support to Importing DataFrames from / Exporting DataFrames to multiple formats.

http://www.rubydoc.info/github/athityakumar/daru-io/master/

MIT License

25 stars 9 forks source link

[WIP] Ports all IO modules from daru #16

Closed athityakumar closed 7 years ago

athityakumar commented 7 years ago

[x] from_plaintext
[x] from_csv
[x] from_html
[x] from_excel
[x] from_sql
[x] from_activerecord
[x] write_csv
[x] write_excel
[x] write_sql

athityakumar commented 7 years ago

Thanks @lokeshh. 🎉

Any other changes to be made, @zverok @v0dro?

v0dro commented 7 years ago

Metaprogramming is a good approach. However, follow a general convention that all compulsory arguments (like the dataframe) object are kept as normal arguments and options are keywords. This way you are prevented from writing extra code. You can keep the metaprogramming.

v0dro commented 7 years ago

Also my apologies for the delay in reviews. I'm preparing for my Japanese language test (its on 2nd July), which is taking up most of my time.

athityakumar commented 7 years ago

@v0dro - Sure, compulsory arguments are kept as normal arguments and others are either keyword arguments or options hash, as per the current state of this PR. Also, all the best for the language test! 👍

v0dro commented 7 years ago

Yeah works. This PR is a go-ahead from my side so far. You just need to finish the write_sql and then feel free to merge.