search

SciRuby / daru-io

daru-io is a plugin gem to the existing daru gem, which aims to add support to Importing DataFrames from / Exporting DataFrames to multiple formats.
http://www.rubydoc.info/github/athityakumar/daru-io/master/
MIT License
24 stars 9 forks source link

Compability with Ruby 2.5.x and Rails 5 #76

Closed rstammer closed 4 years ago

rstammer commented 5 years ago

Hi SciRuby-Community / daru-io maintainers 👋

I wanted to experiment with daru-io in a Rails-5/Ruby 2.5.x environment and noticed it won't work out-of-the-box. So I decided trying to upgrade/ope the dependencies so that it will.

On my way to make it work I stumbled over a problem of jsonpath with Ruby 2.5.1 because of some failing tests. Luckily the bug has been quickly fixed by the jsonpath maintainers shortly after I reported it. That's why I added the lower version boundary for jsonpath here.

Since this is my first PR to the project I hope the PR is on par with your style ad guidelines. If not, I'd be happy for som feedback.

rstammer commented 5 years ago

There are some problems with the travis build: Travis is not able to install rserve via R/Cran:

bildschirmfoto 2018-11-01 um 19 58 15

Hm, I can't see a direct connection to the proposed changes yet 🤔