SciRuby / daru-view

daru-view is for easy and interactive plotting in web application & IRuby notebook. daru-view is a plugin gem to the existing daru gem.
https://sciruby.github.io/daru-view/
MIT License
95 stars 20 forks source link

Rename Daru::DataTables::DataTable to Daru::View::DataTable #114

Closed Prakriti-nith closed 6 years ago

Prakriti-nith commented 6 years ago

Updated specs and renamed Daru::DataTables::DataTable to Daru::View::DataTable. This PR runs in parallel with #22 in daru-data_tables, so some of the test cases will not work right now.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 671


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/daru/view/adapters/datatables.rb 1 3 33.33%
spec/table_spec.rb 0 2 0.0%
spec/adapters/datatables_spec.rb 3 6 50.0%
<!-- Total: 4 11 36.36% -->
Files with Coverage Reduction New Missed Lines %
lib/daru/view.rb 1 98.55%
lib/daru/view/table.rb 1 93.75%
lib/daru/view/adapters/googlecharts/display.rb 2 96.55%
spec/table_spec.rb 4 100.0%
lib/daru/view/adapters/nyaplot/iruby_notebook.rb 4 40.0%
lib/daru/view/adapters/googlecharts.rb 10 91.53%
lib/daru/view/adapters/datatables.rb 11 93.33%
spec/adapters/datatables_spec.rb 56 100.0%
<!-- Total: 89 -->
Totals Coverage Status
Change from base Build 660: 0.7%
Covered Lines: 3131
Relevant Lines: 3177

💛 - Coveralls
Shekharrajak commented 6 years ago

Please finish it as soon as possible.

Prakriti-nith commented 6 years ago

@Shekharrajak I have tried the examples again, I think the PR is fine.

Shekharrajak commented 6 years ago

Refer https://github.com/Shekharrajak/daru-data_tables/issues/24